aboutsummaryrefslogtreecommitdiff
path: root/src/libexpr
diff options
context:
space:
mode:
authorTuomas Tynkkynen <tuomas@tuxera.com>2018-02-13 01:32:29 +0200
committerTuomas Tynkkynen <tuomas@tuxera.com>2018-02-16 04:39:43 +0200
commitf67a7007a230c84015793794277c0449e682ab54 (patch)
tree09c737041a4a06badf2548c279f3274280ca4418 /src/libexpr
parent3a5a241b3209f14f8801b902ba20b5cb0666c9df (diff)
libexpr: Pre-reserve space in string in unescapeStr()
Avoids some malloc() traffic.
Diffstat (limited to 'src/libexpr')
-rw-r--r--src/libexpr/lexer.l7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/libexpr/lexer.l b/src/libexpr/lexer.l
index 28a0a6a87..e5e01fb58 100644
--- a/src/libexpr/lexer.l
+++ b/src/libexpr/lexer.l
@@ -49,9 +49,10 @@ static void adjustLoc(YYLTYPE * loc, const char * s, size_t len)
}
-static Expr * unescapeStr(SymbolTable & symbols, const char * s)
+static Expr * unescapeStr(SymbolTable & symbols, const char * s, size_t length)
{
string t;
+ t.reserve(length);
char c;
while ((c = *s++)) {
if (c == '\\') {
@@ -150,7 +151,7 @@ or { return OR_KW; }
/* It is impossible to match strings ending with '$' with one
regex because trailing contexts are only valid at the end
of a rule. (A sane but undocumented limitation.) */
- yylval->e = unescapeStr(data->symbols, yytext);
+ yylval->e = unescapeStr(data->symbols, yytext, yyleng);
return STR;
}
<STRING>\$\{ { PUSH_STATE(INSIDE_DOLLAR_CURLY); return DOLLAR_CURLY; }
@@ -178,7 +179,7 @@ or { return OR_KW; }
return IND_STR;
}
<IND_STRING>\'\'\\. {
- yylval->e = unescapeStr(data->symbols, yytext + 2);
+ yylval->e = unescapeStr(data->symbols, yytext + 2, yyleng - 2);
return IND_STR;
}
<IND_STRING>\$\{ { PUSH_STATE(INSIDE_DOLLAR_CURLY); return DOLLAR_CURLY; }