diff options
| author | Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com> | 2023-01-06 13:07:57 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-06 13:07:57 +0100 |
| commit | 8d88c3b34768219c26db2da8547cb02378779b39 (patch) | |
| tree | 568308fbb558d9b0d39c73433cc817757c2480d5 /src/libstore/build/derivation-goal.cc | |
| parent | 420ccecc1ebfd1b8dc6b98ab1fb67081d2f4be9a (diff) | |
| parent | bcd298d39bffbb1a79ae5ce2c4eec8c45fa9f2a0 (diff) | |
Merge pull request #7307 from hercules-ci/derivation-goal-improve-comment
libstore/derivation-goal: Elaborate a TODO for performance concern
Diffstat (limited to 'src/libstore/build/derivation-goal.cc')
| -rw-r--r-- | src/libstore/build/derivation-goal.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/libstore/build/derivation-goal.cc b/src/libstore/build/derivation-goal.cc index 173058d1b..5e86b5269 100644 --- a/src/libstore/build/derivation-goal.cc +++ b/src/libstore/build/derivation-goal.cc @@ -544,7 +544,8 @@ void DerivationGoal::inputsRealised() However, the impure derivations feature still relies on this fragile way of doing things, because its builds do not have a representation in the store, which is a usability problem - in itself */ + in itself. When implementing this logic entirely with lookups + make sure that they're cached. */ if (auto outPath = get(inputDrvOutputs, { depDrvPath, j })) { worker.store.computeFSClosure(*outPath, inputPaths); } |