diff options
author | Jade Lovelace <lix@jade.fyi> | 2024-03-29 20:26:38 -0700 |
---|---|---|
committer | Jade Lovelace <lix@jade.fyi> | 2024-03-29 20:26:38 -0700 |
commit | 1fa6a3e3354bd98707303476b5a54147ccdd533a (patch) | |
tree | c3804cca7a9ec266de780019a95180e20387c92f /src/libstore/build/goal.hh | |
parent | 99f159c5367e423097fe4347375bdfc4f76d2c0c (diff) |
Fix various clang-tidy lints
* some things that can throw are marked noexcept
yet the linter seems to think not. Maybe they can't throw in practice.
I would rather not have the UB possibility in pretty obvious cold
paths.
* various default-case-missing complaints
* a fair pile of casts from integer to character, which are in fact
deliberate.
* an instance of <https://clang.llvm.org/extra/clang-tidy/checks/bugprone/move-forwarding-reference.html>
* bugprone-not-null-terminated-result on handing a string to curl in
chunks of bytes. our usage is fine.
* reassigning a unique_ptr by CRIMES instead of using release(), then
using release() and ignoring the result. wild. let's use release() for
its intended purpose.
Change-Id: Ic3e7affef12383576213a8a7c8145c27e662513d
Diffstat (limited to 'src/libstore/build/goal.hh')
0 files changed, 0 insertions, 0 deletions