diff options
author | eldritch horrors <pennae@lix.systems> | 2024-08-13 15:34:55 +0200 |
---|---|---|
committer | eldritch horrors <pennae@lix.systems> | 2024-08-19 09:13:44 +0000 |
commit | 5e9db0976158e6990c99fe3cb1b2ec0bd41d7d28 (patch) | |
tree | 56ffcd005d88c6ea54517ae2f4862621bc855308 /src/libstore/build/hook-instance.hh | |
parent | e513cd2bebe6c4ed012bd4d2e92650c67f0df4bf (diff) |
libstore: downsize hook pipes
don't keep fds open we're not using. currently this does not cause any
problems, but it does increase the size of our fd table needlessly and
in the future, when we have proper async processing, having builderOut
open in the daemon once the hook has been fully started is problematic
Change-Id: I6e7fb773b280b042873103638d3e04272ca1e4fc
Diffstat (limited to 'src/libstore/build/hook-instance.hh')
-rw-r--r-- | src/libstore/build/hook-instance.hh | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/libstore/build/hook-instance.hh b/src/libstore/build/hook-instance.hh index 481158296..b8632d299 100644 --- a/src/libstore/build/hook-instance.hh +++ b/src/libstore/build/hook-instance.hh @@ -10,19 +10,19 @@ namespace nix { struct HookInstance { /** - * Pipes for talking to the build hook. + * Pipe for talking to the build hook. */ - Pipe toHook; + AutoCloseFD toHook; /** * Pipe for the hook's standard output/error. */ - Pipe fromHook; + AutoCloseFD fromHook; /** * Pipe for the builder's standard output/error. */ - Pipe builderOut; + AutoCloseFD builderOut; /** * The process ID of the hook. |