diff options
| author | eldritch horrors <pennae@lix.systems> | 2024-09-25 23:57:46 +0200 |
|---|---|---|
| committer | eldritch horrors <pennae@lix.systems> | 2024-09-29 12:09:24 +0000 |
| commit | 3f7519526f7e2cd3ede01c3910fbfe2ddf0f051f (patch) | |
| tree | c477bae7e352bab85849ca85bcbbb52bfd1200e1 /src/libstore/build/local-derivation-goal.hh | |
| parent | 289e7a6b5a84c64142a10bdd875f8a06e3987579 (diff) | |
libstore: have makeLocalDerivationGoal return unique_ptrs
these can be unique rather than shared because shared_ptr has a
converting constructor. preparatory refactor for something else
and not necessary on its own, and the extra allocations we must
do for shared_ptr control blocks isn't usually relevant anyway.
Change-Id: I5391715545240c6ec8e83a031206edafdfc6462f
Diffstat (limited to 'src/libstore/build/local-derivation-goal.hh')
| -rw-r--r-- | src/libstore/build/local-derivation-goal.hh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libstore/build/local-derivation-goal.hh b/src/libstore/build/local-derivation-goal.hh index 6239129ab..52b7d4c2e 100644 --- a/src/libstore/build/local-derivation-goal.hh +++ b/src/libstore/build/local-derivation-goal.hh @@ -182,7 +182,7 @@ struct LocalDerivationGoal : public DerivationGoal * Create a LocalDerivationGoal without an on-disk .drv file, * possibly a platform-specific subclass */ - static std::shared_ptr<LocalDerivationGoal> makeLocalDerivationGoal( + static std::unique_ptr<LocalDerivationGoal> makeLocalDerivationGoal( const StorePath & drvPath, const OutputsSpec & wantedOutputs, Worker & worker, @@ -194,7 +194,7 @@ struct LocalDerivationGoal : public DerivationGoal * Create a LocalDerivationGoal for an on-disk .drv file, * possibly a platform-specific subclass */ - static std::shared_ptr<LocalDerivationGoal> makeLocalDerivationGoal( + static std::unique_ptr<LocalDerivationGoal> makeLocalDerivationGoal( const StorePath & drvPath, const BasicDerivation & drv, const OutputsSpec & wantedOutputs, |