libstore: remove upcast_goal

upcast_goal was only ever needed to break circular includes, but the
same solution that gave us upcast_goal also lets us fully remove it:
just upcast goals without a wrapper function, but only in .cc files.

Change-Id: I9c71654b2535121459ba7dcfd6c5da5606904032

1 files changed, 0 insertions, 11 deletions

diff --git a/src/libstore/build/worker.cc b/src/libstore/build/worker.cc
index a7a298c34..e3fec292a 100644
--- a/src/libstore/build/worker.cc
+++ b/src/libstore/build/worker.cc
@@ -537,15 +537,4 @@ void Worker::markContentsGood(const StorePath & path)
     pathContentsGoodCache.insert_or_assign(path, true);
 }
 
-
-GoalPtr upcast_goal(std::shared_ptr<PathSubstitutionGoal> subGoal)
-{
-    return subGoal;
-}
-
-GoalPtr upcast_goal(std::shared_ptr<DrvOutputSubstitutionGoal> subGoal)
-{
-    return subGoal;
-}
-
 }