diff options
| author | eldritch horrors <pennae@lix.systems> | 2024-10-05 00:38:35 +0200 |
|---|---|---|
| committer | eldritch horrors <pennae@lix.systems> | 2024-10-05 19:53:30 +0000 |
| commit | 40f154c0edc53e160b70fc60b2b5b8652dfbe84b (patch) | |
| tree | c4c19a15d1eb2b6ccefe72a2e446c383386c6782 /src/libstore/build/worker.hh | |
| parent | f389a5407916ba311faa50ec053f7ebac2a608b5 (diff) | |
libstore: remove Worker::topGoals
since we now propagate goal exceptions properly we no longer need to
check topGoals for a reason to abort early. any early abort reasons,
whether by exception or a clean top goal failure, can now be handled
by inspecting the goal result in the main loop. this greatly reduces
goal-to-goal interactions that do not happen at the main loop level.
since the underscore-free name is now available for use as variables
we'll migrate to that where we currently use `_topGoals` for locals.
Change-Id: I5727c5ea7799647c0a69ab76975b1a03a6558aa6
Diffstat (limited to 'src/libstore/build/worker.hh')
| -rw-r--r-- | src/libstore/build/worker.hh | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/src/libstore/build/worker.hh b/src/libstore/build/worker.hh index 26832c3b1..fa1031907 100644 --- a/src/libstore/build/worker.hh +++ b/src/libstore/build/worker.hh @@ -91,11 +91,6 @@ private: bool running = false; - /** - * The top-level goals of the worker. - */ - Goals topGoals; - template<typename G> struct CachedGoal { @@ -172,7 +167,7 @@ private: statisticsUpdateInhibitor = {}; } - kj::Promise<Result<void>> runImpl(Targets _topGoals); + kj::Promise<Result<void>> runImpl(Targets topGoals); kj::Promise<Result<void>> boopGC(LocalStore & localStore); public: |