diff options
| author | eldritch horrors <pennae@lix.systems> | 2024-10-05 00:38:35 +0200 |
|---|---|---|
| committer | eldritch horrors <pennae@lix.systems> | 2024-10-05 18:21:02 +0000 |
| commit | 896a123605b825cd0a1548fc40da1a757ca30d25 (patch) | |
| tree | 43a423d6797189c8cc1eeaeac59a0fe0a70c0b32 /src/libstore/build/worker.hh | |
| parent | 86b213e6321540328fb11c3ea99c0b24becc45b0 (diff) | |
libstore: remove Goal::StillAlive
this was a triumph. i'm making a note here: huge success. it's hard to
overstate my satisfaction! i'm not even angry. i'm being so sincere ri
actually, no. we *are* angry. this was one dumbass odyssey. nobody has
asked for this. but not doing it would have locked us into old, broken
protocols forever or (possibly worse) forced us to write our own async
framework building on the old did-you-mean-continuations in Worker. if
we had done that we'd be locked into ever more, and ever more complex,
manual state management all over the place. this just could not stand.
Change-Id: I43a6de1035febff59d2eff83be9ad52af4659871
Diffstat (limited to 'src/libstore/build/worker.hh')
| -rw-r--r-- | src/libstore/build/worker.hh | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/libstore/build/worker.hh b/src/libstore/build/worker.hh index cd49fb860..d0bf742c5 100644 --- a/src/libstore/build/worker.hh +++ b/src/libstore/build/worker.hh @@ -139,8 +139,7 @@ private: */ bool checkMismatch = false; - void goalFinished(GoalPtr goal, Goal::Finished & f); - void handleWorkResult(GoalPtr goal, Goal::WorkResult how); + void goalFinished(GoalPtr goal, Goal::WorkResult & f); kj::Own<kj::PromiseFulfiller<void>> childFinished; |