diff options
| author | John Ericson <John.Ericson@Obsidian.Systems> | 2023-04-13 10:38:35 -0400 |
|---|---|---|
| committer | John Ericson <John.Ericson@Obsidian.Systems> | 2023-04-14 08:29:06 -0400 |
| commit | a6f85e052c916f1589414be1a8ba999aff993296 (patch) | |
| tree | 6f71b11396861ecc2ebd2d89afa3bb04f6340849 /src/libstore/remote-store.hh | |
| parent | f5ab38a688031ada1ea52203911e313acdb52e08 (diff) | |
Support `repairPath` on most stores.
More progress on issue #5729
The method trivially generalizes to be store-implementation-agnostic, in
fact.
However, we force it to continue to be unimplemented with `RemoteStore`
and `LegacySSHStore` because the implementation we'd get via the
generalization is probably not the one users expect. This keeps our
hands untied to do it right going forward.
For more about the tension between the scheduler logic being
store-type-agnostic and remote stores doing their own scheduling, see
issues #5025 and #5056.
Diffstat (limited to 'src/libstore/remote-store.hh')
| -rw-r--r-- | src/libstore/remote-store.hh | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/libstore/remote-store.hh b/src/libstore/remote-store.hh index 1c45f543e..0da039837 100644 --- a/src/libstore/remote-store.hh +++ b/src/libstore/remote-store.hh @@ -136,6 +136,17 @@ public: bool verifyStore(bool checkContents, RepairFlag repair) override; + /** + * The default instance would schedule the work on the client side, but + * for consistency with `buildPaths` and `buildDerivation` it should happen + * on the remote side. + * + * We make this fail for now so we can add implement this properly later + * without it being a breaking change. + */ + void repairPath(const StorePath & path) override + { unsupported("repairPath"); } + void addSignatures(const StorePath & storePath, const StringSet & sigs) override; void queryMissing(const std::vector<DerivedPath> & targets, |