diff options
author | Maximilian Bosch <maximilian@mbosch.me> | 2021-09-26 15:20:36 +0200 |
---|---|---|
committer | Maximilian Bosch <maximilian@mbosch.me> | 2021-09-27 15:44:39 +0200 |
commit | bb1a851bcf1bf62b5d943ba25d57b680711a64c6 (patch) | |
tree | 71877d4d617218c31c8cbb1a064b8cadc691176d /src/libstore/sqlite.hh | |
parent | a0bb5c4130268edbd368a4a07d4a30f1064e9c86 (diff) |
build: also throw hash-mismatch errors if `buildMode == bmCheck`
This actually bit me quite recently in `nixpkgs` because I assumed that
`nix-build --check` would also error out if hashes don't match anymore[1]
and so I wrongly assumed that I couldn't reproduce the mismatch error.
The fix is rather simple, during the output registration a so-called
`delayedException` is instantiated e.g. if a FOD hash-mismatch occurs.
However, in case of `nix-build --check` (or `--rebuild` in case of `nix
build`), the code-path where this exception is thrown will never be
reached.
By adding that check to the if-clause that causes an early exit in case
of `bmCheck`, the issue is gone. Also added a (previously failing)
test-case to demonstrate the problem.
[1] https://github.com/NixOS/nixpkgs/pull/139238, the underlying issue
was that `nix-prefetch-git` returns different hashes than `fetchgit`
because the latter one fetches submodules by default.
Diffstat (limited to 'src/libstore/sqlite.hh')
0 files changed, 0 insertions, 0 deletions