diff options
| author | Théophane Hufschmitt <theophane.hufschmitt@tweag.io> | 2023-04-07 09:16:40 +0200 |
|---|---|---|
| committer | Théophane Hufschmitt <theophane.hufschmitt@tweag.io> | 2023-04-07 09:21:50 +0200 |
| commit | 214f1d67910e491e0bd7e1f09f0623fdffd82d48 (patch) | |
| tree | d605b28e1ddffa733d1e13173f9b39dab139af06 /src/libutil/hash.hh | |
| parent | 91856396317995aa38dc7244357596b8de27f937 (diff) | |
Rename and protect `BufferedSink::write`
The `write` name is ambiguous and could lead to some funny bugs like
https://github.com/NixOS/nix/pull/8173#issuecomment-1500009480. So
rename it to the more explicit `writeUnbuffered`.
Besides, this method shouldn't be (and isn't) used outside of the class
implementation, so mark it `protected`.
This makes it more symetrical to `BufferedSource` which uses a
`protected readUnbuffered` method.
Diffstat (limited to 'src/libutil/hash.hh')
| -rw-r--r-- | src/libutil/hash.hh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libutil/hash.hh b/src/libutil/hash.hh index be1fdba2a..ae3ee40f4 100644 --- a/src/libutil/hash.hh +++ b/src/libutil/hash.hh @@ -197,7 +197,7 @@ public: HashSink(HashType ht); HashSink(const HashSink & h); ~HashSink(); - void write(std::string_view data) override; + void writeUnbuffered(std::string_view data) override; HashResult finish() override; HashResult currentHash(); }; |