aboutsummaryrefslogtreecommitdiff
path: root/src/libutil/tests/tests.cc
diff options
context:
space:
mode:
authorTobias Pflug <tobias.pflug@gmail.com>2020-05-08 15:13:55 +0200
committerTobias Pflug <tobias.pflug@gmail.com>2020-05-08 15:13:55 +0200
commit181a47d8845e06edc9653e99de589376a1a96bb6 (patch)
tree3d990fc5dc0d3f4b0afa004a433ead0f0e93fa32 /src/libutil/tests/tests.cc
parent2191141274cfefcb9ffbafbbfcdc58414fb28f1a (diff)
Enable toLower umlauts test
Update comment and enable the test
Diffstat (limited to 'src/libutil/tests/tests.cc')
-rw-r--r--src/libutil/tests/tests.cc10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/libutil/tests/tests.cc b/src/libutil/tests/tests.cc
index d46f6a5a4..5abfe2c9c 100644
--- a/src/libutil/tests/tests.cc
+++ b/src/libutil/tests/tests.cc
@@ -301,12 +301,12 @@ namespace nix {
ASSERT_EQ(toLower(s), s);
}
- // XXX: std::tolower() doesn't cover this. This probably doesn't matter
- // since the context is paths and store paths specifically where such
- // characters are not allowed.
- TEST(toLower, DISABLED_umlauts) {
+ // std::tolower() doesn't handle unicode characters. In the context of
+ // store paths this isn't relevant but doesn't hurt to record this behavior
+ // here.
+ TEST(toLower, umlauts) {
auto s = "ÄÖÜ";
- ASSERT_EQ(toLower(s), "äöü");
+ ASSERT_EQ(toLower(s), "ÄÖÜ");
}
/* ----------------------------------------------------------------------------