diff options
author | Eelco Dolstra <edolstra@gmail.com> | 2021-10-06 13:54:59 +0200 |
---|---|---|
committer | Eelco Dolstra <edolstra@gmail.com> | 2021-10-06 13:54:59 +0200 |
commit | c6718a9d95021476f0cca47b61479e4046090f4e (patch) | |
tree | 1d21975f7d3e19b464321e0b9e15342b9531160a /src/libutil/util.hh | |
parent | ce9823d9b7d2fc73ec2bce521450430c9bc413b6 (diff) |
Don't reset the logger in a vfork
9c766a40cbbd3a350a9582d0fd8201e3361a63b2 broke logging from the
daemon, because commonChildInit is called when starting the build hook
in a vfork, so it ends up resetting the parent's logger. So don't
vfork.
It might be best to get rid of vfork altogether, but that may cause
problems, e.g. when we call an external program like git from the
evaluator.
Diffstat (limited to 'src/libutil/util.hh')
-rw-r--r-- | src/libutil/util.hh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libutil/util.hh b/src/libutil/util.hh index 6d3e64949..29232453f 100644 --- a/src/libutil/util.hh +++ b/src/libutil/util.hh @@ -262,7 +262,7 @@ struct ProcessOptions string errorPrefix = ""; bool dieWithParent = true; bool runExitHandlers = false; - bool allowVfork = true; + bool allowVfork = false; }; pid_t startProcess(std::function<void()> fun, const ProcessOptions & options = ProcessOptions()); |