diff options
| author | eldritch horrors <pennae@lix.systems> | 2024-06-16 23:10:09 +0200 |
|---|---|---|
| committer | eldritch horrors <pennae@lix.systems> | 2024-06-17 19:46:44 +0000 |
| commit | ad5366c2ad43216ac9a61ccb1477ff9859d1a75c (patch) | |
| tree | e986b1f0e9510641279bba164b36bae9a96be6be /src/nix-env/nix-env.cc | |
| parent | b8f49a8eaf619df6d228f2e0f9814c4a5fa4aec5 (diff) | |
libexpr: pass Exprs as references, not pointers
almost all places where Exprs are passed as pointers expect the pointers
to be non-null. pass them as references to encode this constraint in the
type system as well (and also communicate that Exprs must not be freed).
Change-Id: Ia98f166fec3c23151f906e13acb4a0954a5980a2
Diffstat (limited to 'src/nix-env/nix-env.cc')
| -rw-r--r-- | src/nix-env/nix-env.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nix-env/nix-env.cc b/src/nix-env/nix-env.cc index 227a3331c..283d3a3a7 100644 --- a/src/nix-env/nix-env.cc +++ b/src/nix-env/nix-env.cc @@ -413,7 +413,7 @@ static void queryInstSources(EvalState & state, loadSourceExpr(state, *instSource.nixExprPath, vArg); for (auto & i : args) { - Expr * eFun = state.parseExprFromString(i, state.rootPath(CanonPath::fromCwd())); + Expr & eFun = state.parseExprFromString(i, state.rootPath(CanonPath::fromCwd())); Value vFun, vTmp; state.eval(eFun, vFun); vTmp.mkApp(&vFun, &vArg); |