aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorregnat <rg@regnat.ovh>2021-06-29 13:53:56 +0200
committerregnat <rg@regnat.ovh>2021-06-29 13:56:48 +0200
commit4cff8188a5b59303f726a2497727fff34f9711d3 (patch)
treef3f8f1928f08f6286695bee870f492069cc0aff3 /src
parent81535022dcf80ad43ba8b8bfa2549858431b601f (diff)
Keep the `isFlake` attribute for overriden inputs
When overriding an input that isn’t a flake, mark the override as also not being a flake. Fix #3774
Diffstat (limited to 'src')
-rw-r--r--src/libexpr/flake/flake.cc7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/libexpr/flake/flake.cc b/src/libexpr/flake/flake.cc
index 2e94490d4..8e6f06949 100644
--- a/src/libexpr/flake/flake.cc
+++ b/src/libexpr/flake/flake.cc
@@ -359,7 +359,12 @@ LockedFlake lockFlake(
ancestors? */
auto i = overrides.find(inputPath);
bool hasOverride = i != overrides.end();
- if (hasOverride) overridesUsed.insert(inputPath);
+ if (hasOverride) {
+ overridesUsed.insert(inputPath);
+ // Respect the “flakeness” of the input even if we
+ // override it
+ i->second.isFlake = input2.isFlake;
+ }
auto & input = hasOverride ? i->second : input2;
/* Resolve 'follows' later (since it may refer to an input