Remove some designated initializers

With the switch to C++20, the rules became more strict, and we can no
longer initialize base classes. Make them comments instead.

(BTW
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2287r1.html
this offers some new syntax for this use-case. Hopefully this will be
adopted and we can eventually use it.)

15 files changed, 20 insertions, 20 deletions

diff --git a/src/libexpr/primops.cc b/src/libexpr/primops.cc
index 8b54c4477..4e2f92276 100644
--- a/src/libexpr/primops.cc
+++ b/src/libexpr/primops.cc
@@ -1287,7 +1287,7 @@ drvName, Bindings * attrs, Value & v)
                 .method = method,
                 .hash = h,
             },
-            .references = {},
+            /* .references = */ {},
         });
         drv.env["out"] = state.store->printStorePath(outPath);
         drv.outputs.insert_or_assign("out",
@@ -2103,7 +2103,7 @@ static void addPath(
                     .method = method,
                     .hash = *expectedHash,
                 },
-                .references = {},
+                /* .references = */ {},
             });
 
         if (!expectedHash || !state.store->isValidPath(*expectedStorePath)) {
diff --git a/src/libexpr/primops/fetchTree.cc b/src/libexpr/primops/fetchTree.cc
index e194462e4..69395ad3d 100644
--- a/src/libexpr/primops/fetchTree.cc
+++ b/src/libexpr/primops/fetchTree.cc
@@ -240,7 +240,7 @@ static void fetch(EvalState & state, const PosIdx pos, Value * * args, Value & v
                     .method = unpack ? FileIngestionMethod::Recursive : FileIngestionMethod::Flat,
                     .hash = *expectedHash,
                 },
-                .references = {}
+                /* .references = */ {}
             });
 
         if (state.store->isValidPath(expectedPath)) {
diff --git a/src/libfetchers/fetchers.cc b/src/libfetchers/fetchers.cc
index 3936eadfe..dae4998f9 100644
--- a/src/libfetchers/fetchers.cc
+++ b/src/libfetchers/fetchers.cc
@@ -215,7 +215,7 @@ StorePath Input::computeStorePath(Store & store) const
             .method = FileIngestionMethod::Recursive,
             .hash = *narHash,
         },
-        .references = {},
+        /* .references = */ {},
     });
 }
 
diff --git a/src/libfetchers/tarball.cc b/src/libfetchers/tarball.cc
index 302046610..b6f72bb1f 100644
--- a/src/libfetchers/tarball.cc
+++ b/src/libfetchers/tarball.cc
@@ -78,7 +78,7 @@ DownloadFileResult downloadFile(
                     .method = FileIngestionMethod::Flat,
                     .hash = hash,
                 },
-                .references = {},
+                /* .references = */ {},
             },
             hashString(htSHA256, sink.s),
         };
diff --git a/src/libstore/binary-cache-store.cc b/src/libstore/binary-cache-store.cc
index 9cb0f74f6..5617e2c42 100644
--- a/src/libstore/binary-cache-store.cc
+++ b/src/libstore/binary-cache-store.cc
@@ -313,7 +313,7 @@ StorePath BinaryCacheStore::addToStoreFromDump(Source & dump, std::string_view n
                     .method = method,
                     .hash = nar.first,
                 },
-                .references = {
+                /* .references = */ {
                     .others = references,
                     .self = false,
                 },
@@ -431,7 +431,7 @@ StorePath BinaryCacheStore::addToStore(
                     .method = method,
                     .hash = h,
                 },
-                .references = {
+                /* .references = */ {
                     .others = references,
                     .self = false,
                 },
diff --git a/src/libstore/build/local-derivation-goal.cc b/src/libstore/build/local-derivation-goal.cc
index 8fdc9dce1..cfd5db3b4 100644
--- a/src/libstore/build/local-derivation-goal.cc
+++ b/src/libstore/build/local-derivation-goal.cc
@@ -2498,7 +2498,7 @@ DrvOutputs LocalDerivationGoal::registerOutputs()
                         .method = outputHash.method,
                         .hash = got,
                     },
-                    .references = rewriteRefs(),
+                    /* .references = */ rewriteRefs(),
                 },
                 Hash::dummy,
             };
diff --git a/src/libstore/content-address.cc b/src/libstore/content-address.cc
index a51646d0f..39a31f0a0 100644
--- a/src/libstore/content-address.cc
+++ b/src/libstore/content-address.cc
@@ -167,13 +167,13 @@ ContentAddressWithReferences caWithoutRefs(const ContentAddress & ca) {
         [&](const TextHash & h) -> ContentAddressWithReferences {
             return TextInfo {
                 h,
-                .references = {},
+                /* .references = */ {},
             };
         },
         [&](const FixedOutputHash & h) -> ContentAddressWithReferences {
             return FixedOutputInfo {
                 h,
-                .references = {},
+                /* .references = */ {},
             };
         },
     }, ca);
diff --git a/src/libstore/local-store.cc b/src/libstore/local-store.cc
index c6f870dde..9d2ea7156 100644
--- a/src/libstore/local-store.cc
+++ b/src/libstore/local-store.cc
@@ -1419,7 +1419,7 @@ StorePath LocalStore::addToStoreFromDump(Source & source0, std::string_view name
             .method = method,
             .hash = hash,
         },
-        .references = {
+        /* .references = */ {
             .others = references,
             .self = false,
         },
diff --git a/src/libstore/make-content-addressed.cc b/src/libstore/make-content-addressed.cc
index 42de79226..59a452918 100644
--- a/src/libstore/make-content-addressed.cc
+++ b/src/libstore/make-content-addressed.cc
@@ -56,7 +56,7 @@ std::map<StorePath, StorePath> makeContentAddressed(
                     .method = FileIngestionMethod::Recursive,
                     .hash = narModuloHash,
                 },
-                .references = std::move(refs),
+                /* .references = */ std::move(refs),
             },
             Hash::dummy,
         };
diff --git a/src/libstore/path-info.cc b/src/libstore/path-info.cc
index 5944afd06..ff85b3932 100644
--- a/src/libstore/path-info.cc
+++ b/src/libstore/path-info.cc
@@ -31,7 +31,7 @@ std::optional<ContentAddressWithReferences> ValidPathInfo::contentAddressWithRef
             assert(references.count(path) == 0);
             return TextInfo {
                 th,
-                .references = references,
+                /* .references = */ references,
             };
         },
         [&](const FixedOutputHash & foh) -> ContentAddressWithReferences {
@@ -43,7 +43,7 @@ std::optional<ContentAddressWithReferences> ValidPathInfo::contentAddressWithRef
             }
             return FixedOutputInfo {
                 foh,
-                .references = {
+                /* .references = */ {
                     .others = std::move(refs),
                     .self = hasSelfReference,
                 },
diff --git a/src/libstore/store-api.cc b/src/libstore/store-api.cc
index 3c0c26706..295ce4953 100644
--- a/src/libstore/store-api.cc
+++ b/src/libstore/store-api.cc
@@ -234,7 +234,7 @@ std::pair<StorePath, Hash> Store::computeStorePathForPath(std::string_view name,
             .method = method,
             .hash = h,
         },
-        .references = {},
+        /* .references = */ {},
     };
     return std::make_pair(makeFixedOutputPath(name, caInfo), h);
 }
@@ -443,7 +443,7 @@ ValidPathInfo Store::addToStoreSlow(std::string_view name, const Path & srcPath,
                 .method = method,
                 .hash = hash,
             },
-            .references = {},
+            /* .references = */ {},
         },
         narHash,
     };
diff --git a/src/nix-store/nix-store.cc b/src/nix-store/nix-store.cc
index 5b261ecc6..28ddf2f4a 100644
--- a/src/nix-store/nix-store.cc
+++ b/src/nix-store/nix-store.cc
@@ -220,7 +220,7 @@ static void opPrintFixedPath(Strings opFlags, Strings opArgs)
             .method = method,
             .hash = Hash::parseAny(hash, hashAlgo),
         },
-        .references = {},
+        /* .references = */ {},
     })));
 }
 
diff --git a/src/nix/add-to-store.cc b/src/nix/add-to-store.cc
index 81dbc09a6..5de1aebfc 100644
--- a/src/nix/add-to-store.cc
+++ b/src/nix/add-to-store.cc
@@ -49,7 +49,7 @@ struct CmdAddToStore : MixDryRun, StoreCommand
                     .method = std::move(ingestionMethod),
                     .hash = std::move(hash),
                 },
-                .references = {},
+                /* .references = */ {},
             },
             narHash,
         };
diff --git a/src/nix/prefetch.cc b/src/nix/prefetch.cc
index df9933d29..bc270f66d 100644
--- a/src/nix/prefetch.cc
+++ b/src/nix/prefetch.cc
@@ -72,7 +72,7 @@ std::tuple<StorePath, Hash> prefetchFile(
                 .method = ingestionMethod,
                 .hash = *expectedHash,
             },
-            .references = {},
+            /* .references = */ {},
         });
         if (store->isValidPath(*storePath))
             hash = expectedHash;
diff --git a/src/nix/profile.cc b/src/nix/profile.cc
index 345505532..e552e8975 100644
--- a/src/nix/profile.cc
+++ b/src/nix/profile.cc
@@ -206,7 +206,7 @@ struct ProfileManifest
                     .method = FileIngestionMethod::Recursive,
                     .hash = narHash,
                 },
-                .references = {
+                /* .references = */ {
                     .others = std::move(references),
                     .self = false,
                 },